xinglin commented on code in PR #6804:
URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594843688
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java:
##########
@@ -64,7 +64,11 @@ public void
updateResponseState(RpcHeaderProtos.RpcResponseHeaderProto.Builder h
*/
@Override
public void receiveResponseState(RpcHeaderProtos.RpcResponseHeaderProto
header) {
- sharedGlobalStateId.accumulate(header.getStateId());
+ if (header.getStateId() == 0 && sharedGlobalStateId.get() > 0) {
Review Comment:
We can remove the `sharedGlobalStateId.get() > 0`, right?
If sharedGlobalStateId.get() < 0, routers already fallback to active and no
need to reset. If it is > 0 and then we see a request without StateID, we will
reset this counter and routers will fallback to active.
Adding `sharedGlobalStateId.get() > 0` doesn't seem to make a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
