-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/
-----------------------------------------------------------
(Updated 2010-11-02 13:32:50.159119)
Review request for hadoop-common.
Changes
-------
Incorporated Todd's comments. Thank you!
- Added unit tests for ReconfigurationUtil.getChangedProperties, Reconfigurable
interface methods and cross-thread visibility of configuration changes.
- Added proper escaping to servlet.
- Removed synchronization from Configuration methods that were already
protected by synchronization of getProps(). In this revision, I have only added
synchronization to the setter methods.
- Changed getReconfigurableProperties to return Collection rather than List.
- Fixed typo.
- Removed commented-out code.
- Removed unnecessary imports.
Summary
-------
Allow configuration changes without restarting configured nodes
This addresses bug HADOOP-7001.
https://issues.apache.org/jira/browse/HADOOP-7001
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
1026174
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java
PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java
PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java
PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java
PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java
PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestReconfiguration.java
PRE-CREATION
Diff: https://reviews.apache.org/r/21/diff
Testing
-------
Manual testing with Reconfigurable NameNode from
https://issues.apache.org/jira/browse/HDFS-1477
Thanks,
Patrick
