----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21/#review22 -----------------------------------------------------------
I'm not so sure about making all of the Configuration methods synchronized. For one in terms of deadlock possibility, for two in terms of performance. Is this really necessary? http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java <https://reviews.apache.org/r/21/#comment11> typo: a the http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java <https://reviews.apache.org/r/21/#comment12> Collection<String> seems more general http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java <https://reviews.apache.org/r/21/#comment13> why commented out? http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java <https://reviews.apache.org/r/21/#comment14> need escaping on all interpolated values throughout http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java <https://reviews.apache.org/r/21/#comment15> this could be unit tested - Todd On 2010-11-01 20:31:22, Patrick Kling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21/ > ----------------------------------------------------------- > > (Updated 2010-11-01 20:31:22) > > > Review request for hadoop-common. > > > Summary > ------- > > Allow configuration changes without restarting configured nodes > > > This addresses bug HADOOP-7001. > https://issues.apache.org/jira/browse/HADOOP-7001 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java > 1026174 > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21/diff > > > Testing > ------- > > Manual testing with Reconfigurable NameNode from > https://issues.apache.org/jira/browse/HDFS-1477 > > > Thanks, > > Patrick > >
