Nexory commented on code in PR #1880:
URL: https://github.com/apache/wicket/pull/1880#discussion_r4549551116
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.js:
##########
@@ -158,7 +158,13 @@ function MultiSelector( eprefix, list_target, max,
useMultipleAttr, del_label ){
};
// Set row value
- contentsColumn.innerHTML = this.getOnlyFileNames(element);
+ var fileNames = this.getOnlyFileNamesAsArray(element);
Review Comment:
Done as you suggest: `addListRow` is back to its original form and passes
the markup of `getOnlyFileNames()` through `Wicket.TrustedTypes.html()`.
`getOnlyFileNamesAsArray()`, the two deprecations and the section in
`migration-to-12.md` are gone, and a test for the disabled mode checks that an
overridden `getOnlyFileName()` or `getOnlyFileNames()` changes the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]