Nexory commented on code in PR #1880:
URL: https://github.com/apache/wicket/pull/1880#discussion_r4546234664


##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -1467,7 +1543,7 @@
                                        // jQuery 1.9+ expects '<' as the very 
first character in text
                                        const cleanedText = text.trim();
 
-                                       const $newElement = jQuery(cleanedText);
+                                       const $newElement = 
jQuery(toMarkup(cleanedText));

Review Comment:
   Done in afcb17a as you describe: with the option, `replace` and `add` parse 
with a `template` element and `reviveScripts` and insert with the DOM API, the 
removed element still goes through `jQuery(element).remove()`, and `toMarkup` 
is gone. Two differences from the jQuery path remain with the option: 
`jQuery.htmlPrefilter` is not called, and external scripts load after inline 
ones.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to