dashorst commented on PR #1845:
URL: https://github.com/apache/wicket/pull/1845#issuecomment-6790082473

   Thanks @papegaaij. 7c743a48f3 takes all the inline suggestions and the three 
general points:
   
   - A skip link is now the first tab stop. `#content` gets `role="main"`, and 
`#toc` gets `role="navigation"` with `aria-label="Table of contents"`.
   - Copy buttons are named after their language ("Copy Java code", or "Copy 
code" for listings without one).
   - "Copied" goes to a single visually hidden `role="status"` element instead 
of `aria-live` on each button.
   
   I checked the result in Chromium: 539 buttons and six distinct labels, one 
status region, and `aria-current` on the current TOC entry. A focused chapter 
link shows its sections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to