dashorst opened a new pull request, #1845: URL: https://github.com/apache/wicket/pull/1845
Restyles the reference guide in the design of wicket.apache.org and restores syntax highlighting, which the guide has not had: the pom passed `<sourceHighlighter>`, a parameter asciidoctor-maven-plugin 2.x does not know and ignores, so all of the guide's 500+ listings rendered as plain text. Closes #1844. The copied 2017 default stylesheet is gone. The plugin's own default stylesheet loads first, and `css/wicket.css` overrides it through docinfo with the site's tokens, its self-hosted Alegreya and JetBrains Mono fonts and its Rouge colours. The page makes no external requests any more (no Google Fonts, no Font Awesome from cdnjs). - **Code:** Rouge through the `source-highlighter` attribute. Every listing has a language label and a copy button. In HTML samples, `wicket:id` and the `wicket:` tags are marked. - **Navigation:** a masthead with links to the site, the line's Javadoc and the other versions. The table of contents is drawn as the site's ribbon rail, highlights the section in view and opens only that chapter. - **Blocks:** notes and warnings become asides on the tint with an orange rule. Tables get an ink rule above and hairlines between rows. - **Dark mode** follows the system setting. ## Before and after | Before | After | |---|---| |  |  | |  |  | |  |  | |  |  | | (no dark mode) |  | ## For review - **Core:** `css/wicket.css`, `js/guide.js`, the three `docinfo*.html` files, and the `pom.xml` and `single.adoc` attribute changes. - **Mechanical:** the font files and their licence texts (copied from the site repo), `img/wicket-mark.svg`, `LICENSE` and `.rat-excludes`. - **Licensing:** the fonts are SIL OFL 1.1 and are listed in LICENSE next to the example fonts. The Asciidoctor (MIT) entry and `licenses/LICENSE-asciidoctor.txt` are removed because the copied stylesheet they covered is gone. - **Serif body:** the body text is serif again, as on the site, which reverses WICKET-6372. - **Copied tokens:** the design tokens are copied from the site's `_sass/ribbon/_base.scss` and have to be kept in step by hand. - **PDF:** keeps its font icons and is otherwise unchanged. Tested with `mvn clean verify -Pjs-test` (green) and `mvn -pl wicket-user-guide -Pguide generate-resources`. The rendered guide was checked at 1440px and 390px, in light and dark mode, in Chromium. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
