dashorst commented on code in PR #1865:
URL: https://github.com/apache/wicket/pull/1865#discussion_r4524914094
##########
pom.xml:
##########
@@ -249,15 +249,15 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>jakarta.el</groupId>
- <artifactId>jakarta.el-api</artifactId>
- <version>${jakarta.el-api.version}</version>
+ <groupId>jakarta.cdi</groupId>
+ <artifactId>jakarta.cdi-api</artifactId>
Review Comment:
Confirmed and fixed in e305d80041: `dependency:tree` showed
`jakarta.enterprise.cdi-api` 4.1.0 in both modules, next to
`jakarta.cdi:jakarta.cdi-api` 5.0.0 in wicket-examples.
Excluding only `jakarta.enterprise.cdi-api` wasn't enough: `jetty-ee11-plus`
also depends on `jakarta.enterprise:jakarta.enterprise.lang-model` 4.1.0
directly, and it carries the same `jakarta.enterprise.lang.model` packages as
`jakarta.cdi-lang-model-api` 5.0.0. The entry now excludes both. After that,
wicket-examples has only the `jakarta.cdi` 5.0.0 artifacts, and
wicket-native-websocket-javax has no CDI API on its test classpath. Its Jetty
websocket tests still pass, as does the full `mvn clean verify -Pjs-test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]