papegaaij commented on code in PR #1865:
URL: https://github.com/apache/wicket/pull/1865#discussion_r4524829299
##########
pom.xml:
##########
@@ -249,15 +249,15 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>jakarta.el</groupId>
- <artifactId>jakarta.el-api</artifactId>
- <version>${jakarta.el-api.version}</version>
+ <groupId>jakarta.cdi</groupId>
+ <artifactId>jakarta.cdi-api</artifactId>
Review Comment:
Switching to the new coordinate is right, but with the management entry for
`jakarta.enterprise:jakarta.enterprise.cdi-api` gone, nothing pins the old
coordinate any more. Jetty still depends on it:
`jetty-ee11-websocket-jakarta-server` → `jetty-ee11-annotations` →
`jetty-ee11-plus` → `jakarta.enterprise:jakarta.enterprise.cdi-api`
(unversioned, so Jetty's BOM decides). Before this change the managed 5.0.0
relocated it onto `jakarta.cdi:jakarta.cdi-api`; now it resolves to 4.1.0 in
wicket-examples and wicket-native-websocket-javax. Those modules then carry
`jakarta.enterprise.*` twice, 4.1.0 from Jetty and 5.0.0 under the new
coordinate. `dependencyConvergence` doesn't see it because the coordinates
differ.
Could you exclude the old coordinate from the Jetty dependency? The
`jetty-ee11-websocket-jakarta-server` entry in the root
`<dependencyManagement>` covers both modules:
```xml
<dependency>
<groupId>org.eclipse.jetty.ee11.websocket</groupId>
<artifactId>jetty-ee11-websocket-jakarta-server</artifactId>
<version>${jetty.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-api</artifactId>
</exclusion>
</exclusions>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]