Cole-Greer commented on code in PR #3458: URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3463866087
########## gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/GremlinLangTraversalRoundTripTest.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal; + +import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource; +import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__; +import org.apache.tinkerpop.gremlin.language.grammar.GremlinAntlrToJava; +import org.apache.tinkerpop.gremlin.language.grammar.GremlinQueryParser; +import org.apache.tinkerpop.gremlin.structure.util.empty.EmptyGraph; +import org.junit.Test; + +import static org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource.traversal; +import static org.junit.Assert.assertEquals; + +/** + * Tests that GremlinLang serialization round-trips preserve traversal arguments. + * For any step containing a child traversal argument, serializing to GremlinLang and parsing back + * produces a structurally equivalent traversal. + */ +public class GremlinLangTraversalRoundTripTest { Review Comment: I've gone with option 3, and built this class out to be more well rounded. It's not a single parameterized test with 45 to give more complete coverage. The main gap that this test fills is validating GremlinLang strigification/parsing roundtrip equality. To an extent this was already covered through feature tests which are parsed from the gherkin source, and then stringified for remote execution, however that only verifies the traversal produces the expected results, which is weaker than asserting equal traversals through the round trip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
