GumpacG commented on code in PR #3466: URL: https://github.com/apache/tinkerpop/pull/3466#discussion_r3463318848
########## docs/src/reference/gremlin-variants.asciidoc: ########## @@ -991,24 +991,27 @@ The following table describes the various configuration options for the Gremlin |auth.password |The password to submit on requests that require basic authentication. |_none_ |auth.region |The region setting for sigv4 authentication. |_none_ |auth.serviceName |The service name setting for sigv4 authentication. |_none_ -|connectionPool.connectionSetupTimeoutMillis | Duration of time in milliseconds provided for connection setup to complete which includes the SSL handshake. |15000 +|connectionPool.compression |The wire compression algorithm negotiated with the server. Can be: `NONE` or `DEFLATE`. |DEFLATE +|connectionPool.connectTimeout | Duration of time in milliseconds that bounds TCP connection establishment (transport setup, including the SSL handshake). Formerly `connectionSetupTimeoutMillis`, which is still accepted as a deprecated alias. |5000 |connectionPool.enableSsl |Determines if SSL should be enabled or not. If enabled on the server then it must be enabled on the client. |false -|connectionPool.idleConnectionTimeout | Duration of time in milliseconds that the driver will allow a channel to not receive read or writes before it automatically closes. |180000 +|connectionPool.idleTimeout | Duration of time in milliseconds that the driver will allow a channel to not receive read or writes before it automatically closes. Formerly `idleConnectionTimeoutMillis`, which is still accepted as a deprecated alias. |180000 Review Comment: As discussed offline we will keep the millis suffix and add a separate option to follow language idiomatic units. https://lists.apache.org/thread/nwhob2gtnkdhj64o16jlyqost1g6c7c4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
