GumpacG opened a new pull request, #3466: URL: https://github.com/apache/tinkerpop/pull/3466
# Standardize `gremlin-driver` (Java) connection options Implements the Java portion of the TinkerPop 4.x GLV connection-options standardization. Renames several options to canonical names (old names kept as deprecated aliases), aligns defaults, adds new options, and removes one. Reference-driver changes only; the other GLVs follow in separate PRs. **Proposal:** https://lists.apache.org/thread/yqtr2wnb1kq2pqqq4002cz511q5o0bkg ## Renames (deprecated aliases retained) | Old | New | Default | |-----|-----|---------| | `maxConnectionPoolSize` | `maxConnections` | 128 | | `idleConnectionTimeoutMillis` | `idleTimeout` | 180s | | `connectionSetupTimeoutMillis` | `connectTimeout` | 5s | | `resultIterationBatchSize` | `defaultBatchSize` | 64 | | individual SSL builders | `ssl(SslContext)` | - | | `RequestOptions.addG` | `traversalSource` | - | ## Behavior changes (breaking) - **`connectTimeout`** default lowered 15s → 5s, and it is now actually applied (it was previously validated but never enforced, so connection setup was effectively unbounded). - **`compression`** now defaults to `DEFLATE` (on); the driver sends `Accept-Encoding: deflate` by default. Set `Compression.NONE` to disable. - **`validationRequest`** builder default reconciled to `g.inject(0)`. ## New options - **`readTimeout`** (default off) - streaming-safe idle-read timeout, armed per request. - **`keepAliveTime`** (30s) - idle time before TCP keep-alive probes (`SO_KEEPALIVE` + `TCP_KEEPIDLE` where supported). - **`maxResponseHeaderBytes`** (8192) - previously hardcoded. - **`proxy(ProxyOptions)`** and **`url(String)`**. ## Removed (breaking) - **`maxResponseContentLength`** - responses now stream; `readTimeout` is the partial mitigation. ## Testing - `gremlin-driver` unit tests pass, including new `ConnectionOptionsTest` and `ReadTimeoutHandlerTest`. - `gremlin-server` integration tests updated: a new `readTimeout` cleanup/recovery test replaces the removed cap-based tests. - CHANGELOG, reference config table, and upgrade guide updated. Assisted-by: Kiro: Claude Opus 4.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
