Cole-Greer commented on PR #3395: URL: https://github.com/apache/tinkerpop/pull/3395#issuecomment-4356447687
@kenhuuu > Is there a test for checking that the GraphBinaryReader handles values that are input across chunk boundaries? This is technically covered by the new tests for the StreamReader, but it isn't quite the integration test that I'm expecting as it doesn't go from test input through the GraphBinary deserializers. I've added some cases at the end of [GraphBinaryReader-test.js](https://github.com/apache/tinkerpop/pull/3395/files#diff-20fdc9b9a769c017fbab412994fc9f21e09e524a6207be28240c98d8b6e1c11e) to give more coverage here. They validate that GraphBinaryReader can handle items split across chunk boundaries, as well as validating it can incrementally produce the first result prior to all data being available in to the stream. It doesn't quite reach the level of a full integration test as it's not wired into DRC. Such a test would be useful but needs dedicated server infrastructure, which I consider out of scope here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
