GumpacG commented on code in PR #3395:
URL: https://github.com/apache/tinkerpop/pull/3395#discussion_r3158696884
##########
gremlin-js/gremlin-javascript/test/unit/graphbinary/error-cases-test.js:
##########
@@ -26,365 +26,380 @@
import { assert } from 'chai';
import { Buffer } from 'buffer';
import ioc from '../../../lib/structure/io/binary/GraphBinary.js';
+import StreamReader from
'../../../lib/structure/io/binary/internals/StreamReader.js';
import { P, TextP, Traverser } from '../../../lib/process/traversal.js';
import { OptionsStrategy } from '../../../lib/process/traversal-strategy.js';
const { anySerializer, intSerializer, longSerializer, stringSerializer,
listSerializer, mapSerializer, uuidSerializer, dateTimeSerializer,
floatSerializer, shortSerializer, byteSerializer, bigIntegerSerializer,
binarySerializer, setSerializer, enumSerializer } = ioc;
Review Comment:
Should this test file cover all serializer errors? For example, there is a
missing UnspecifiedNullSerializer error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
