andreachild commented on code in PR #3215:
URL: https://github.com/apache/tinkerpop/pull/3215#discussion_r2380237199
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java:
##########
@@ -202,42 +208,43 @@ public VertexProperty.Cardinality getCardinality() {
@Override
public Object getKey() {
- List<Object> keyParams = parameters.get(T.key, null);
+ List<Object> keyParams = internalParameters.get(T.key, null);
return keyParams.isEmpty() ? null : keyParams.get(0);
}
@Override
public Object getValue() {
- List<Object> values = parameters.get(T.value, null);
+ List<Object> values = internalParameters.get(T.value, null);
return values.isEmpty() ? null : values.get(0);
}
@Override
public String toString() {
- return StringFactory.stepString(this, this.parameters);
+ return StringFactory.stepString(this, this.internalParameters);
}
@Override
public AddPropertyStep<S> clone() {
final AddPropertyStep<S> clone = (AddPropertyStep<S>) super.clone();
- clone.parameters = this.parameters.clone();
+ clone.internalParameters = this.internalParameters.clone();
+ clone.withConfiguration = this.withConfiguration.clone();
return clone;
}
@Override
public void addProperty(Object key, Object value) {
- configure(key, value);
+ configureInternalParams(key, value);
Review Comment:
Nit:
```suggestion
this.internalParameters.set(this, key, value);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
