andreachild commented on code in PR #3215: URL: https://github.com/apache/tinkerpop/pull/3215#discussion_r2380240055
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java: ########## @@ -48,41 +48,46 @@ * @author Marko A. Rodriguez (http://markorodriguez.com) */ public class AddPropertyStep<S extends Element> extends SideEffectStep<S> - implements AddPropertyStepContract<S>, Writing<Event.ElementPropertyChangedEvent>, Deleting<Event.ElementPropertyChangedEvent>, Configuring { + implements AddPropertyStepContract<S>, Writing<Event.ElementPropertyChangedEvent>, Deleting<Event.ElementPropertyChangedEvent> { - private Parameters parameters = new Parameters(); + private Parameters internalParameters = new Parameters(); + private Parameters withConfiguration = new Parameters(); private final VertexProperty.Cardinality cardinality; private CallbackRegistry<Event.ElementPropertyChangedEvent> callbackRegistry; public AddPropertyStep(final Traversal.Admin traversal, final VertexProperty.Cardinality cardinality, final Object keyObject, final Object valueObject) { super(traversal); - this.parameters.set(this, T.key, keyObject, T.value, valueObject); + this.internalParameters.set(this, T.key, keyObject, T.value, valueObject); this.cardinality = cardinality; } @Override public Parameters getParameters() { - return this.parameters; + return this.withConfiguration; } @Override public Set<String> getScopeKeys() { - return this.parameters.getReferencedLabels(); + return this.internalParameters.getReferencedLabels(); } @Override public <S, E> List<Traversal.Admin<S, E>> getLocalChildren() { - return this.parameters.getTraversals(); + return this.internalParameters.getTraversals(); } @Override public void configure(final Object... keyValues) { - this.parameters.set(this, keyValues); + this.withConfiguration.set(this, keyValues); + } + + private void configureInternalParams(final Object... keyValues) { Review Comment: Nit: this method is just one line and called once so not very useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
