Cole-Greer commented on code in PR #3214:
URL: https://github.com/apache/tinkerpop/pull/3214#discussion_r2377357421
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/VertexStepPlaceholder.java:
##########
@@ -180,4 +180,9 @@ public void updateVariable(String name, Object value) {
public Collection<GValue<?>> getGValues() {
return Arrays.asList(edgeLabels);
}
+
+ @Override
+ public void close() throws Exception {
Review Comment:
Doing this would require pulling `protected void closeIterator()` from
`FlatMapStep` up to `VertexStepContract` which forces it to be made public as
well. The preferable solution would probably be making FlatMapStep implement
AutoClosable, and pushing `public void close() throws Exception
{closeIterator();}` down into FlatMapStep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
