Cole-Greer commented on code in PR #3214:
URL: https://github.com/apache/tinkerpop/pull/3214#discussion_r2377324996
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/RangeGlobalStepPlaceholder.java:
##########
@@ -126,8 +124,42 @@ public GValue<Long> getHighRangeAsGValue() {
}
@Override
- protected Traverser.Admin<S> processNextStart() throws
NoSuchElementException {
- throw new IllegalStateException("RangeGlobalGValueContract is not
executable");
+ protected boolean filter(Traverser.Admin<S> traverser) {
+ throw new IllegalStateException("RangeGlobalStepPlaceholder is not
executable");
+ }
+
+ @Override
+ public void setBypass(final boolean bypass) {
+ this.bypass = bypass;
+ }
+
+ @Override
+ public void processAllStarts() {
+ throw new IllegalStateException("RangeGlobalStepPlaceholder is not
executable");
+ }
+
+ @Override
+ public boolean hasNextBarrier() {
Review Comment:
This is a great intermediate suggestion. I had avoided default
implementations for these methods as `getStarts()` was only available in
AbstractStep, and I didn't think it was within the scope of this PR to migrate
that to Step (although such a change would be worth pursuing). This is a good
fix for now as it prevents the unnecessary code duplication, without expanding
this PR with the added risk of modifying the Step interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
