DanielLeens commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-6730834911
Thanks @li3zhi4. A quick CI update on the unchanged head `b1ae8e964cd02c741479c75ad4abc7335b904854`: my last review said the PR was ready once CI is green, and the fork Build (https://github.com/li3zhi4/seatunnel/actions/runs/42195788415) has now finished red with two jobs that need a look. No source blocker is added by this note. - `unit-test (17, ubuntu-latest)`: `Redis7Test.failedInitializationClosesConnections` (`Redis7Test.java:156`) failed with `expected: <true> but was: <false>` inside its connection-count wait. This diff does not touch the Redis connector, and the other 83 tests in that module passed, so this looks like a timing flake unrelated to the PR. - `connector-file-local-it (11, ubuntu-latest)`: this one is cancelled, not failed. The job hit its time limit while `LocalFileIT` was still running its last cases (the XML ones), and no assertion failure was logged before the cancellation. Because this PR changes `JsonReadStrategy`, I would like to see this job finish green rather than assume it. `dev` has no fix for either, so syncing `dev` would not help. The cheapest next step is "Re-run failed jobs" on that fork run (it re-runs only the two jobs above). Once both are green I will update my review to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
