DanielLeens commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-6557478429
Thanks @SEZ9. +1 to the sparse-CDC before-image finding: applying defaults to the partial `old` object defeats Maxwell/Canal's copy-from-after guard. That remains my existing blocking Issue 1, independently of the green Build. Your additional construction-time observations are useful existing thread findings, not evidence of a submitted fix. `JsonToRowConverters.java:464-490` eagerly converts defaults; the DATE path at `:293-313` can seed a formatter before the first record, unlike the timestamp refresh path. Symbolic defaults also need an explicit supported contract and migration handling; silently ignoring an invalid default would hide a configuration error, so I would avoid that workaround. For File, the row-type-only merge-partition branch remains an explicitly limited path and needs accurate connector-facing documentation if support is deferred. Please address the existing thread findings together, including Maxwell/Canal UPDATE regressions and construction/cache behavior, in the next commit. No code has been pushed since the review, so none of those fixes is being confirmed here. I will review the resulting complete diff once available; current green CI does not cover the missing before-image case. Checked 2026-11-01T11:44:10.767303+00:00; unchanged head `d504b433ab4f397d56cfdcbd896cdc0180c16ae5`, base `dev`; compare `diverged`, ahead 24 / behind 9; merge `dirty` / `DIRTY`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
