SEZ9 commented on issue #13099: URL: https://github.com/apache/seatunnel/issues/13099#issuecomment-6594148302
Thanks for the detailed STIP. A few points I'd like to settle before the design is finalized: 1. The proposal notes that multi-table wrappers currently don't forward `open()`/`close()` to children and that Zeta logs transform-open failures without rethrowing, and suggests reviewing these prerequisites separately. Could you open dedicated issues/PRs for them so they can be reviewed and merged independently of the provider contract? 2. Packaging and discovery: the proposal leaves the location of the shared contract as an open question. Do you have a concrete suggestion for where it should live and how providers should be discovered at runtime, ideally without adding new dependencies to the core transform module? 3. Ciphertext format: the envelope fields (format version, key ID, algorithm, nonce, encrypted data, authentication tag) are listed, and the proposal asks to agree on binary encoding and size limits before implementation. Could you propose a concrete byte layout (field order, length encoding, limits) so reviewers can evaluate it? A short compatibility matrix covering legacy vs. new format for read and write in the docs would also help. <!-- streview-comment:2242 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
