zhangshenghang commented on PR #12459:
URL: https://github.com/apache/seatunnel/pull/12459#issuecomment-6593283123
All six findings are addressed, thanks for restating them at the new head.
Commit e080aebdd:
- Issue 1: the first heap check now uses `jcmd <pid> GC.heap_info` (works on
JDK 8+; `jmap -heap` removal on JDK 9+ is called out) and the sample output is
labeled as a JDK 8 reference. `jmap -dump`/`-histo:live` kept as valid.
- Issue 2: the `log_group_size` row is removed from the SLS sink tables
(EN/ZH) so the docs no longer teach a config that the validator rejects;
registering it in `SlsSinkFactory` is left for a separate code PR.
- Issue 3: the `du` commands are scoped to local file storage
(`fs.defaultFS` starting with `file:///`) and a backend-aware example (`hadoop
fs -du -s -h <fs-uri>/<namespace>`) was added next to each, keeping the
no-selective-deletion warning.
- Issue 4: `engine_runningJobInfo` is now described as submitted job
information and initialization metadata, pointing metrics at
`engine_finishedJobMetrics` (EN/ZH).
- Issue 5: the ZH 6.3 heading is aligned with EN ("从显式 Savepoint 路径恢复").
- Issue 6: the PR description is refreshed — the stale Databend bullet is
removed and a status-update section documents the dev merges and this round of
fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]