DanielLeens commented on PR #11597: URL: https://github.com/apache/seatunnel/pull/11597#issuecomment-6592035058
@SEZ9 thanks for verifying the asynchronous operation against the diff and for closing that finding. **CI.** Agreed, there is no executed evidence for `38f1ca01d7bace05a0dec8627c5143f6002ddca6`. I checked just now: fork run 41162604738 is still `completed` / `cancelled` (success=7, cancelled=77, skipped=12) and there is no newer attempt on this head. I am not claiming a pass. **One remaining source item, which is mine.** My own review of this head left a comment-only request open: the new helpers in `RunningJobSlotUsageBuilder` (the four-argument `build` overload, `aggregateSlotUsage`, `aggregatePipelineSlots`, `belongsToRunningJob`, `containsOwnedSlots`, `buildAssignedSlotSet`, `isAssignedToJob`, and the `SlotKey` identity fields) have no explanatory comments for the snapshot-availability and stale-slot rules. That is not fixed on this head. I plan to add those comments with no logic change, and, since that creates a new head, I would rather run the full CI once on that head than re-run the cancelled jobs on the current one. If you would prefer I re-run the cancelled jobs on `38f1ca01d` first, say so and I will do that instead. The smaller non-blocking test controls from my review (partial-lag cluster flag, sequence-only slot reuse, synchronous executor rejection, JSON content type) are also not added yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
