DanielLeens commented on PR #13008: URL: https://github.com/apache/seatunnel/pull/13008#issuecomment-6580597745
Pushed `f6358dc6ba` for the 2026-11-01 review on `c7f7680336`. **Issue 2 (tag cache is not injective)** - `seatunnel-engine/seatunnel-engine-ui/src/views/managers/index.tsx` (`selectMonitor`, `updateTags`, Update button). I took the smaller option from the review rather than a new row editor: when selecting a worker, the editor now detects existing tags that cannot be shown as one unambiguous `key=value` line (a line break in a key or value, or two entries that serialize to the same line, such as `a=b -> c` and `a -> b=c`). In that case it shows an explanation and disables **Update Tags** (also re-checked inside `updateTags`), so a save can never silently drop or alter an existing tag. **Clear Tags** stays available because it is an explicit full replacement. The server contract and the legacy tag behavior are unchanged; the representable round-trip cases (`=` in a key, whitespace in a value, literal `__proto__`) keep their existing test. - Test: `managers.spec.ts` `blocks updating when existing tags are unrepresentable` runs both the colliding-pair case and the line-break case and asserts the button is disabled, the explanation is shown and `updateTags` is never called. On the previous code both cases submit a map that is missing an entry. **Issue 4 (documented error text)** - `docs/en|zh/engines/zeta/rest-api-v2.md`: the `/update-local-member-tags` error table and example now show the exact `IllegalArgumentException: <message>` text produced by the shared filter, matching what `RestApiIT` and `BasicAuthenticationIT` assert; the filter itself is untouched. **CI**: fork Build for this head is running at https://github.com/DanielLeens/seatunnel/actions/runs/41468624094 (the previous head's run was cancelled, so it gave no result). Local validation was scoped Prettier and `git diff --check` only. **Merge state**: still conflicting with `dev` in exactly two files, `docs/en|zh/introduction/concepts/incompatible-changes.md`. A dev sync for those two pages is pending and not part of this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
