SEPURI-SAI-KRISHNA commented on PR #13023: URL: https://github.com/apache/seatunnel/pull/13023#issuecomment-6542959803
@DanielLeens thanks, all three are addressed in the new commit. 1. BINARY: I took Option B. The BINARY mapping is back to what `dev` has, and this PR now fixes only the DECIMAL part of #13022. Declaring BYTES while the driver still returns Strings would claim support the values do not have. The declared type and the value conversion belong together in a follow-up, which needs a server that really stores binary, since the E2E image parses `BINARY` as `STRING`. 2. Upgrade note: added to `incompatible-changes.md` in en and zh. A Databend `DECIMAL(p, s)` column now reaches the job as `DECIMAL(p, s)` instead of STRING, the Turkish/Azerbaijani case is included, and the migration step is `CAST(... AS STRING)` where a downstream step needs text. 3. Locale restore: `theMappingIsIndependentOfTheDefaultLocale` now snapshots the base locale and the `FORMAT` and `DISPLAY` defaults and restores them, base first. Also in this commit, from SEZ9's review on #13022: a `decimal(76, 10)` case and the capitalized `Decimal(10, 2)` form in `decimalKeepsItsPrecisionAndScale`, and a comment at the DECIMAL branch that precision and scale come from `COLUMN_SIZE` and `DECIMAL_DIGITS`. I checked against databend-jdbc 0.3.7 that `TYPE_NAME` drops the `Nullable(...)` wrapper (`Nullable(Decimal(10, 2))` gives `Decimal(10, 2)`, 10, 2), so a nullable column takes the same path. The branch now has `dev` merged, which was needed for the upgrade note to apply cleanly. Checks, JDK 17: `connector-databend` 23 tests, 0 failures; with dev's `toUpperCase()` restored, the DECIMAL and locale tests fail. `spotless:check` clean; `seatunnel-ci-tools` 34 tests, 0 failures. The PR title and description are updated. @nzw921rx the Assert sink E2E you asked for is in place since `9d47249cd`; could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
