SEPURI-SAI-KRISHNA commented on PR #13023: URL: https://github.com/apache/seatunnel/pull/13023#issuecomment-6489198355
@nzw921rx thanks, done. `testDatabendTypeMapping` now writes to an Assert sink instead of Console: - exactly 1 row (`MIN_ROW` and `MAX_ROW` 1) - `id`: `int`, equal to 1 - `price`: `decimal(10, 2)`, equal to `1234.56` The job declares no schema, so these types come from `DatabendCatalog`. I ran the rules through the real `AssertRuleParser` and `AssertExecutor`. They pass for the row this PR produces (`DecimalType(10, 2)`, `BigDecimal` 1234.56). They fail on `price` for the row `dev` produces (STRING, `"1234.56"`), and for a wrong scale or value. While doing this I found that Databend v1.2.71, the image the E2E uses, parses `BINARY` as an alias of `STRING`, so the previous E2E never covered BINARY. I removed that column from the E2E table, and BINARY stays covered by `DatabendCatalogTest`. I also found that the driver returns a BINARY value as a String, so this PR fixes the declared type of a BINARY column but not its values. The PR description now says so; turning the values into bytes depends on the server's binary output format, so I would do it as a follow-up. The PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
