DanielLeens commented on PR #12015: URL: https://github.com/apache/seatunnel/pull/12015#issuecomment-6396812888
+1 to @SEZ9's request to settle the dotted-key contract with the REST-shaped test already proposed here. Preserving valid existing path semantics matters as much as accepting the regex key: a literal rebuild must not silently change how env's `shade.identifier` and `job.mode` are resolved. Please push the map -> `RestUtil.buildConfig` -> `ConfigShadeUtils.decryptConfig` regression case with the valid dotted keys and the regex key together, and make the semantics table match its assertions. If literal reconstruction changes the valid-key behavior, the narrow invalid-path rescue is the safer direction than changing `toConfig()` globally. The head is unchanged, so I cannot treat that test or compatibility concern as fixed yet. I will wait for the code update; this is clarification of the existing points, not an additional review finding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
