SEZ9 commented on issue #12959:
URL: https://github.com/apache/seatunnel/issues/12959#issuecomment-6379273052

   Thanks for the detailed write-up and for separating the test-ordering 
question from a data-loss claim.
   
   Before the test order changes, please link the exact branch/commit or PR 
that contains `testMysqlCdcInitialStartupWithLatestStop` and the `latest-stop` 
configuration, since the earlier comment notes they could not be located on 
current `dev`. Once the source location is verifiable, a test-only follow-up is 
welcome.
   
   For that PR, please keep the existing time bounds, data assertions and 
fixture unchanged, wait for the bounded job to reach `FINISHED` and check the 
job exit result before asserting final sink values, and run all seven stop-mode 
cases in the class. Please also show how the reordered assertion still fails if 
a post-snapshot CDC update is actually lost, so the change does not mask a real 
loss.
   
   The Failsafe XML summary in the issue body is helpful; a link to the 
attached file or the relevant excerpt in the PR description would make it 
easier for reviewers to follow.
   
   <!-- streview-comment:1993 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to