SEZ9 commented on PR #12129: URL: https://github.com/apache/seatunnel/pull/12129#issuecomment-6331977525
Thanks for the update. With `6d196d4c920` in place and `JobStatusTest` passing in run 39382715814, the CI side looks settled for this PR; the remaining red jobs are in modules outside this change and can be tracked separately. Nothing further is needed here from my side, and my approval stands. One small follow-up, not a blocker: the merge commit left `PhysicalPlan.java` and `JobStatusTest.java` unchanged, so I can't tell from it alone whether the earlier review notes (null `JobStatus` handling in `cancelJob()`/`stopJob()`, the `NOT_YET_STARTED_STATES` Javadoc and mutability, and the pinning test's count/ordinal assertions and Javadoc wording) were already picked up in earlier commits. If any of them are still open, a quick note on whether you'd like to handle them here or in a follow-up would be great. <!-- streview-comment:1946 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
