SEZ9 commented on PR #12129:
URL: https://github.com/apache/seatunnel/pull/12129#issuecomment-6308201064
Thanks for the `dev` sync, @akshar27, and for tracking down the minio Docker
Hub mirror cause behind the two unrelated `all-connectors-it` failures on
`408f1e0`.
On the review scope: the diff of `PhysicalPlan.java` and
`JobStatusTest.java` between `408f1e0` and `8d66e18f` is empty, and the
follow-up merge `6d196d4c920` also leaves both files untouched. So the six
earlier points stay resolved as reviewed on `408f1e0`:
- F1 – null `JobStatus` fails fast in `cancelJob()`/`stopJob()` rather than
falling through to the CANCELING path.
- F2 / F6 – the `NOT_YET_STARTED_STATES` Javadoc now states why `SCHEDULED`
is excluded, and the confusing sentence in the pinning-test Javadoc is cleaned
up.
- F3 – the pinning test asserts the count plus per-index ordinals, so a
drift points at the exact constant.
- F4 – the test Javadoc is scoped to same-build protection and no longer
implies it covers mixed-version clusters.
- F5 – `NOT_YET_STARTED_STATES` is wrapped in `Collections.unmodifiableSet`.
Nothing to re-review there from my side.
On CI: the last `Build` result is run 35455329329 from 2026-09-19.
`unit-test` (which runs `JobStatusTest`) and `all-connectors-it-6` were green
there; the red `engine-v2-it (11)` and `all-connectors-it-2` jobs are in
modules this PR doesn't touch and line up with the dev-baseline failures of
that period, so I'm not treating them as blockers for this change.
Remaining ask: your fork didn't produce a `Build` run for `6d196d4c920`.
Could you kick one off from the Actions tab ("Run workflow" on Build) so the
apache `Build` check picks up the current head? Once that run is in, and
assuming `unit-test` stays green, I'm good to move this forward. If
`engine-v2-it (11)` or `all-connectors-it-2` are still red on the fresh run,
please just note it here and we'll track it separately rather than in this PR.
<!-- streview-comment:1924 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
