DanielLeens commented on PR #10060:
URL: https://github.com/apache/seatunnel/pull/10060#issuecomment-6286871373
Pushed merge commit `5fdae45bc21` (current `dev` into your branch),
@Mrhs121; no conflicts and the PR's own files are unchanged, the goal is a
fresh CI run on a current base. On the open review item about a public API
change in `SeaTunnelSparkDataWriter` (Spark 3.3): I re-read the diff and no
method signature is removed or changed; `close()` already existed as a no-op
and now closes the sink writer and emits `WriterCloseEvent`, while `abort()`
moves the same cleanup into a `try/finally`. So from my side that item is a
behavior change inside existing methods, not an API break, and I have no new
source-level blocker. Your fork did not create a Build run for this push; if
none appears, please start one from the Actions tab ("Run workflow" on Build).
Verification run of the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr10060-verify-5fdae45bc21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
