DanielLeens commented on PR #11652:
URL: https://github.com/apache/seatunnel/pull/11652#issuecomment-6286847899
Pushed `1b5e7600c54` on top of your branch, @waterWang (merge of the current
`dev` plus one test-only commit) to close the test-coverage blocker from the
reviews. `tests/test_connector_metadata.py` gains three cases following the
existing `patch.object(connectors, ...)` pattern: the
missing-`connector_metadata.json` path now asserts a WARNING log line with the
`--export-metadata` hint via `assertLogs`; `get_connector_detail("Doris")` with
empty metadata must return the known-connector remediation message and must not
echo "Did you mean: Doris?"; and other suggestions ("Jdbc") are still offered.
No production line changed. Verification run (the CLI unit tests run in the
`SeaTunnel CLI` workflow):
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11652-verify-1b5e7600c54.
The PR title (`[Fix][CLI] ...`) and the scope note from my review are still
yours to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
