DanielLeens commented on PR #11710: URL: https://github.com/apache/seatunnel/pull/11710#issuecomment-6286048909
Pushed `3cfee73b41c` on top of your branch, @yuxuan-luo (merge of the current `dev` plus one commit) to close the items from my review: - Issue 1 (blocker): new `VerticaTypeMapperTest` with a mocked `ResultSetMetaData` covers `NUMERIC(10,2)` and lower-case `numeric` mapping to `DecimalType(precision, scale)`, `DECIMAL` unchanged, the `precision > 38` fallback to `DECIMAL(38,18)` for both labels, and that an unknown type still throws. The NUMERIC cases fail on `dev` without your fix. - Issue 2: the overflow warning now logs the type string actually reported by the driver instead of the hardcoded `DECIMAL` constant, with a short comment on why NUMERIC and DECIMAL share the branch. - Issue 3: `docs/en|zh/connectors/source/Vertica.md` type-mapping tables now mention `NUMERIC` / `NUMBER` / `MONEY` (reported by the driver as NUMERIC) on the DECIMAL row. Your fork has not produced a Build run; please enable GitHub Actions on it and start the Build workflow from the Actions tab so the apache `Build` check can attach. I started a verification run of the same head on my fork: https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11710-verify-3cfee73b41c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
