DanielLeens commented on PR #11760:
URL: https://github.com/apache/seatunnel/pull/11760#issuecomment-6285934125
Pushed `ed1b54f1ef0` on top of your branch, @waterWang (merge of the current
`dev` plus one commit) to close the three open items from my review:
1. **Headers**: `HttpSourceReader` now also snapshots `rawHeaders` in the
constructor and, when `use_placeholder_replacement` is on, rebuilds the headers
from that template on every page, exactly like your `rawParams` fix. The params
and headers paths share one private `rebuildFromTemplate` helper, so the logic
is not duplicated.
2. **Spotless**: `./mvnw spotless:apply -pl
seatunnel-connectors-v2/connector-http/connector-http-base` applied;
`spotless:check` passes locally for the module.
3. **Regression tests**: `testPageNumberPlaceHolderParamsAdvanceAcrossPages`
and `testPageNumberPlaceHolderHeadersAdvanceAcrossPages` in
`HttpSourceReaderInternalPollNextTest` call `updateRequestParam` for page 1 and
page 2 and assert that the substituted value advances to `2`; on `dev` both
fail because the placeholder is gone after the first call.
Your fork did not create a Build run for this push; if none appears, please
start one from the Actions tab ("Run workflow" on Build). I started a
verification run of the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11760-verify-ed1b54f1ef0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
