DanielLeens commented on PR #11069: URL: https://github.com/apache/seatunnel/pull/11069#issuecomment-6285648059
Status update while going through the open first-time-contributor PRs, @lazyfetch: I tried to sync this branch with `dev` to clear the conflict, and found that the change has been superseded on `dev`. `SeaTunnelRowDebeziumDeserializationConverters` on `dev` already has the `case TIMESTAMP_TZ:` branch (via #10724, `872077f6480`), implemented as `convertToTimestampTz(serverTimeZone)` with a `parseOffsetDateTimeFromString` fallback chain (ISO-8601 offset, IANA zone id, space separator, short hour-only offset) that throws `IllegalArgumentException` with the raw value on an unknown format, plus unit tests for all of those cases in `SeaTunnelRowDebeziumDeserializationConvertersTest`. That covers what this PR adds and also the "wrap the parse and surface the raw value" ask from the review, so both conflicting files resolve to the `dev` version with nothing left from this branch. I did not push anything here. What is not on `dev` yet is the docs note (the `TIMESTAMP_TZ` row in the Postgres CDC type-mapping table), so if you would like to keep contributing on this topic, a small docs-only PR for that would be welcome; otherwise this PR can be closed as superseded by #10724 (a committer call). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
