DanielLeens commented on PR #11771:
URL: https://github.com/apache/seatunnel/pull/11771#issuecomment-6285610892
Pushed `f8108da0574` on top of your branch, @waterWang (merge of the current
`dev` plus one commit) to close the two blocking items from my review:
1. `./mvnw spotless:apply -pl seatunnel-connectors-v2/connector-jdbc`
applied, which fixes the Javadoc wrapping in `JdbcSinkWriter.java` that made
the `Code style` check red (`spotless:check` now passes for the module locally).
2.
`JdbcSinkWriterTest.testApplyConnectionValidationHonorsPropertiesConnectionTestQuery`
covers both `properties.connection-test-query` and
`properties.connectionTestQuery`, asserting that `getConnectionTestQuery()`
returns the user query; it fails on `dev` without this PR's branch in
`applyConnectionValidation`.
No production logic changed. Your fork did not create a Build run for this
push; if none appears, please start one from the Actions tab ("Run workflow" on
Build). I started a verification run of the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11771-verify-f8108da0574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
