DanielLeens commented on PR #10447:
URL: https://github.com/apache/seatunnel/pull/10447#issuecomment-6285340877
Pushed two commits on top of your branch, @Suresh-Krishna-Kusuma:
1. Merge of the current `dev`. Conflicts: `PostgresCDCIT.java`,
`RocketMqContainer.java` and `RocketMqIT.java` (this branch carried a
cherry-pick of #12050 that has since landed on `dev`; resolved by taking the
`dev` versions, so the PR no longer touches those files), and
`HttpSourceReaderInternalPollNextTest.java`, where `dev` added
`testPollIntervalDoesNotHoldCheckpointLock` next to this PR's
`testDefiniteArrayContentFieldProducesOneRowPerElement`; both tests are kept.
2. Issue 1 from my last review: the `$.results` `content_field` default is
now applied only when the effective `format` is `JSON`, both in
`HubSpotSource`'s constructor and in
`HubSpotSourceParameter.buildRuntimeConfig` (new `resolveResponseFormat`
helper). `text` and `binary` keep `content_field` unset, as the base
`HttpSource` intends.
`HubSpotSourceTest.testTextFormatDoesNotForceResultsContentField` pins this (it
fails on the previous head because `contentJson` was `$.results`).
Only `spotless` was run locally. Your fork did not create a Build run for
this push; if none appears, please start one from the Actions tab ("Run
workflow" on Build). I started a verification run of the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr10447-verify-ac79326af75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
