DanielLeens commented on PR #12153: URL: https://github.com/apache/seatunnel/pull/12153#issuecomment-6285279698
Pushed three commits on top of your branch, @zhangsean, so the PR is no longer conflicting and the format blocker is gone: 1. `MysqlCreateTableSqlBuilder.java` and `MysqlCreateTableSqlBuilderTest.java` converted from CRLF to LF (this was the "hundreds of unrelated line changes" from Issue 1; after normalization the real diff is +213/-27 across 3 files). 2. Merge of the current `dev`. The only remaining conflict was in `MysqlCreateTableSqlBuilderTest.java`, where `dev` added `testNullablePrimaryKeyColumnIsNotNullWhenCreateIndex` in the same place as your `testBuildCreateTableSqlWithMysqlFulltextAndPrefixIndexes`; both tests are kept in full. 3. `./mvnw spotless:apply -pl seatunnel-connectors-v2/connector-jdbc` (`spotless:check` now passes locally for the module). No logic was changed. GitHub Actions is still disabled on your fork (`zhangsean/seatunnel` has never had a run), so no `Build` check can attach here until you enable it (Actions tab, then enable workflows) and push an empty commit or start the Build workflow by hand. Meanwhile I started a verification run of this exact head on my fork: https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr12153-verify-093724806b5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
