DanielLeens commented on PR #12882: URL: https://github.com/apache/seatunnel/pull/12882#issuecomment-6282879316
Thanks for digging into the red `Build`, @zhengxiang378928908-code, and for linking the fork run. I checked it against the logs: in fork run 39198018999 (head `8a8c4b86`) the failing jobs are the `unit-test` jobs (11 and 17, ubuntu and windows) plus `edge-agent-it` (11 and 17 on ubuntu), and the unit-test log shows `JdbcOptionRuleCompletenessTest.testSinkRuleDeclaresAllSinkOptions` failing with `Connector 'Jdbc' has unknown option keys: [numeric_special_value_as_null]`. That option was added by #12792 (merged 2026-10-18), the failure is tracked in #12874, and the fix is #12875, which is still open. This PR does not touch JDBC option definitions (it only changes `DamengCatalog`, its tests, `JdbcDmIT` and the incompatible-changes pages), so the failure is unrelated to the diff, and I agree with your plan. Please sync the latest `dev` once #12875 is merged and re-run only the failed jobs; I will take another quick look at the CI result then. My review conclusion on the code itself is unchanged: no source-level blocker, and the remaining gate is a green `Build` on the final head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
