SEZ9 commented on PR #12605: URL: https://github.com/apache/seatunnel/pull/12605#issuecomment-6244650697
Thanks for the status update, @SEPURI-SAI-KRISHNA, and sorry for the slow reply. Yes, I'm still happy to carry this one through, and keeping the `BIGINT` follow-up sequenced after this PR so it can reuse these helpers still seems like the right order to me. Mapping my earlier points against what you describe landing after `c5b287cc5`: - `numberToInt` / `longValue()` wrapping on the `COALESCE`/`IFNULL` path: `22090e713` pinning that a `DECIMAL` beyond long range is rejected through `COALESCE` is exactly the case I was worried about. I haven't inspected `7ab637bf1c` yet, so I'll verify the range check in `SystemFunction.java` there before calling it closed. - `sql-functions.md` wording: `7fd547700` sounds like it addresses this. I'll check on `7ab637bf1c` that the `en` and `zh` text describes what `INT` / `INTEGER` actually enforce, doesn't imply `BIGINT` rejects wide numerics, and reads as reference documentation rather than a before/after narrative. - Error message always saying "CAST of ... to INT" and using `UNSUPPORTED_OPERATION` for a per-row range failure: I don't see this in your list. Could you confirm whether the message/error code was adjusted for the `COALESCE`/`IFNULL` path, or whether you'd prefer to leave it as-is for this PR? Either is fine with me as long as it's deliberate. - `numberToInt` Javadoc narrating history and the `TINYINT`/`SMALLINT` rationale: same question — was that trimmed to the method contract in a later commit? If not, it's a small polish I'd like before merging. So the remaining asks are just a quick confirmation on the last two items (or a small follow-up commit if they're still open). Once that's clear I'll do a final pass on `7ab637bf1c` and move it forward. <!-- streview-comment:1831 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
