SEPURI-SAI-KRISHNA commented on PR #12605: URL: https://github.com/apache/seatunnel/pull/12605#issuecomment-6236290118
Status update rather than a new request, since the head has moved on since this was last looked at. @SEZ9 on #12612 you offered to pick this up at `c5b287cc5`. The current head is `7ab637bf1c`, and three substantive commits landed after `c5b287cc5`, two of them answering points from your own review here: - `22090e713` pins that a `DECIMAL` beyond long range is rejected through `COALESCE`, the case where `longValue()` wraps 2^64 to 0 and a check done after widening would accept it - `7fd547700` documents the integral `CAST` restrictions the SQL transform actually enforces, in `docs/en` and `docs/zh` - `be3a828cf` pins the prepare-time `CAST` rejection and the `COALESCE` truncation that those docs describe The rest of the range is two `dev` merges, the later of which picked up `07d6f2235a` and cleared the `CassandraIT` failures that were red earlier. Current state: - `Build` green, finished 2026-10-14 19:55 UTC, no reruns needed - @DanielLeens approved on 2026-10-14, and that approval sits on the current head `7ab637bf1c` rather than an older commit - `MERGEABLE` against today's `dev` (`c14fef24f`), so no sync is needed - 7 files: `SystemFunction.java`, two test classes, and the `en` and `zh` copies of `incompatible-changes.md` and `sql-functions.md` - No review comments outstanding from anyone One thing that depends on this, so it is visible rather than implied: the `BIGINT` follow-up for #12612 is written and waiting on this to land, because it reuses the helpers this PR introduces rather than adding a near-duplicate `outOfLongRange`. That sequencing was your suggestion and I still think it is the right order, so I am not asking to jump it. No action needed from me that I am aware of. If anything here needs changing before it can go further, I am happy to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
