nzw921rx commented on PR #12420: URL: https://github.com/apache/seatunnel/pull/12420#issuecomment-6118751853
> Thanks @nzw921rx — confirming the disposition of Issue 1 (fallback close queued behind a possibly-blocking `Statement.cancel()` in `JdbcInputFormat.abortInFlight()`): acknowledged and planned as a **follow-up PR**, per @DanielLeens's 10-10 review which classified Issues 1-3 as non-blocking recommended fixes. > > Concretely, the follow-up will harden the fallback path (run the resource close on a separate executor with a timeout so a hung `Statement.cancel()` cannot delay it), clean up the WARN-noise on normal cancellation (Issue 2), and add the engine-side cancel-replay unit test (Issue 3). None of the three affect the correctness of what this PR ships — the in-flight statement abort itself — which is why they were classified non-blocking. Will reference this discussion in the follow-up PR. all right. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
