chovy-3012 commented on PR #12514: URL: https://github.com/apache/seatunnel/pull/12514#issuecomment-6109360479
Thanks @davidzollo. All three issues addressed: **Issue 1 (CRLF):** The old head had CRLF. The current head is LF-only — `git diff --check` passes clean, diff is table-only (84 lines, no whole-file rewrite). **Issue 2 (7 undeclared options):** Confirmed all 7 options are actively consumed by code `CosFileSource` inherits: | Option | Read at | Used for | |--------|---------|----------| | `read_partitions` | `AbstractReadStrategy.java:349` | Filter files by partition | | `csv_use_header_line` | `CsvReadStrategy.java:296` | CSV header parsing | | `binary_chunk_size` | `BinaryReadStrategy.java:74` | Read buffer size | | `binary_complete_file_mode` | `BinaryReadStrategy.java:88` | Whole-file vs chunked read | | `file_filter_modified_start` | `AbstractReadStrategy.java:369` | Filter by start date | | `file_filter_modified_end` | `AbstractReadStrategy.java:375` | Filter by end date | | `sort_files_by_modification_time` | `AbstractReadStrategy.java:385` | Sort files by mtime descending | Consumption path: `CosFileSource → BaseFileSource` calls `setPluginConfig(pluginConfig.toConfig())` (line 77), passing full config to strategies that read these options via `hasPath()`/`getString()`/`getBoolean()`/`getInt()`. This gap exists across all file source factories (Local, S3, Oss, Hdfs, Ftp), not just COS. Options work in normal Zeta runs — only `-v`/Flink/Spark validation rejects them. Should we fix this in the current PR? **Issue 3 (blank descriptions):** Fixed — added descriptions for all 8 previously-blank fields in both en and zh. No blank cells remain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
