chovy-3012 commented on PR #12514: URL: https://github.com/apache/seatunnel/pull/12514#issuecomment-6109292954
Thanks @davidzollo. All three issues addressed: **Issue 1 (CRLF):** Reviewed on old head `b4b6b082` which had CRLF. Current head `caf523671` is LF-only — `git diff --check` passes clean, diff is table-only (84 lines, no whole-file rewrite). **Issue 2 (7 undeclared options):** All 7 options are actively consumed by code `CosFileSource` inherits. Traced each through `connector-file-base`: - `read_partitions` → `AbstractReadStrategy.java:349` (file filtering by partition) - `csv_use_header_line` → `CsvReadStrategy.java:296` (CSV header parsing) - `binary_chunk_size` → `BinaryReadStrategy.java:74` (read buffer size) - `binary_complete_file_mode` → `BinaryReadStrategy.java:88` (whole-file vs chunked read) - `file_filter_modified_start` → `AbstractReadStrategy.java:369` (filter by start date) - `file_filter_modified_end` → `AbstractReadStrategy.java:375` (filter by end date) - `sort_files_by_modification_time` → `AbstractReadStrategy.java:385` (sort files by mtime descending) Consumption path: `CosFileSource → BaseFileSource` calls `readStrategy.setPluginConfig(pluginConfig.toConfig())` (line 77), passing full config to strategies that read these options via `pluginConfig.hasPath()`/`.getString()`/`.getBoolean()`/`.getInt()`. This gap exists across all file source factories (Local, S3, Oss, Hdfs, Ftp), not just COS. Options work in normal Zeta runs — only `-v`/Flink/Spark validation rejects them. I have a fix ready: 7 `.optional()` declarations in `CosFileSourceFactory.optionRule()`. Backward-compatible (no runtime change — code already reads them). Include in this PR, or prefer a separate PR for all file connectors? **Issue 3 (blank descriptions):** Fixed in `caf523671` — added descriptions for all 8 blank fields (`path`, `bucket`, `secret_id`, `secret_key`, `region`, `date_format`, `datetime_format`, `time_format`) in en + zh. No blank cells remain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
