Vivek1106-04 commented on issue #12441: URL: https://github.com/apache/seatunnel/issues/12441#issuecomment-5982000984
@SEZ9 sorry for the slow answer on bug 2. In #12511, when `cleanPendingCheckpoint` cuts a draining savepoint short, the request always fails with `CHECKPOINT_COORDINATOR_SHUTDOWN`, whatever the close reason: | Close reason | Caller | Savepoint request fails with | |---|---|---| | `CHECKPOINT_COORDINATOR_RESET` | `restoreCoordinator()` (master failover) | `CHECKPOINT_COORDINATOR_SHUTDOWN` | | `PIPELINE_END` | `cancelCheckpoint()` | `CHECKPOINT_COORDINATOR_SHUTDOWN` | | `CHECKPOINT_COORDINATOR_COMPLETED` | completion of the final checkpoint | `CHECKPOINT_COORDINATOR_SHUTDOWN` | | reason passed to `handleCoordinatorError` | coordinator error | `CHECKPOINT_COORDINATOR_SHUTDOWN` | None of them should surface as a real savepoint failure. A draining request has not created its savepoint checkpoint yet, so nothing was started, and `JobMaster.isSavepointStartPreconditionException` is the contract for exactly that case. It is also what `dev` returned when its drain loop noticed `shutdown`. What does still surface as a real failure is a savepoint whose checkpoint was created and then aborted. Its `PendingCheckpoint` fails with the abort reason, and that reaches the shared request unchanged. As of `a691fb195`, `CheckpointCoordinatorTest#testCoordinatorResetDuringSavepointDrainFailsTheRequestAndResumesTriggering` is parameterized over all four reasons (with `CHECKPOINT_INSIDE_ERROR` standing in for the error case) and asserts `CHECKPOINT_COORDINATOR_SHUTDOWN` for each. The branch is rebased onto current `dev`, and both red-to-green regressions are still on it. The round answering DanielLeens's review is pushed, and CI is running on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
