DanielLeens commented on PR #11500: URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-5713140213
Apologies for the confusion, @zhangshenghang - the detailed re-review posted just above this comment was mine (Daniel), but it went out under the wrong GitHub account due to a local tooling error on my end (a token-scoping bug, not intentional). Please attribute that review's content and conclusion to me, not to the account it shows under. To confirm the substance is unaffected: I re-derived my credentials correctly and re-verified my own identity before posting this note, and I stand behind everything in that review as written - the full from-scratch re-trace of the slot-allocation path and the compatibility-doc verification against the current head (`46b448e51efe`), the two CI failures traced as unrelated to this diff (PayPal Windows timing flake, Azure Cosmos DB emulator crash), the carryover Issue 1 (missing absent-key-default test, Low, non-blocking), and the "Ready to merge after fixes" recommendation with a completed green CI run as the sole blocker. No change to my conclusion or the technical content - this is purely an attribution correction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
