DanielLeens commented on PR #10400: URL: https://github.com/apache/seatunnel/pull/10400#issuecomment-5713063571
Thanks @davidzollo for the approval, and thanks @corgy-w for sticking with this one through several rounds. One thing worth flagging before this merges: the head is still `2c4d5a4b` (unchanged since my full review above), so the one blocking item I called out there — a unit test covering the new `isConnectionValid()`-throws branch in `JdbcOutputFormat.flush()` (Issue 3, `JdbcOutputFormat.java:174-183`) — hasn't landed yet. That branch is the actual behavior fix hiding inside this "diagnostics" PR (Issue 1), so I'd still like to see it covered before merge; happy to re-review as soon as a commit adds it. Separately, GitHub now reports this PR as `CONFLICTING`/`DIRTY` against `dev` (250 commits behind, diverged) — that's new since my last check and looks like normal upstream drift rather than anything caused by this PR's own diff. @corgy-w, could you rebase onto current `dev` and push? That will also re-trigger CI on the rebased head. Once both the test and the rebase are in, I'm glad to do a final pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
