DanielLeens commented on PR #10453: URL: https://github.com/apache/seatunnel/pull/10453#issuecomment-5713069602
Thanks both for closing this out so cleanly. @wgzhao, appreciate the writeup on #12354 - the layer-by-layer trace (bare `columnType` from `MySqlTypeUtils` through `Column#getSourceType()` to `MysqlCreateTableSqlBuilder`) and the note that only `ALTER TABLE`-added columns are affected, not the snapshot path, is exactly the right level of detail for whoever picks it up next. @SEZ9, agreed - nothing outstanding from source review on either this PR or #12333 at this point. For the record on this thread: head is still `04abfb922`, `mergeStateStatus` is still `BLOCKED` only because the required `Build` check is red, and it's the same unrelated Postgres/openGauss CDC E2E `ConditionTimeoutException` flake I diagnosed last round - not caused by this diff. Nothing further needed from source review; this stays ready to merge from my side once that check is rerun and comes back green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
