nzw921rx commented on code in PR #10595:
URL: https://github.com/apache/seatunnel/pull/10595#discussion_r2944528249


##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java:
##########
@@ -100,20 +100,13 @@ public static Config of(@NonNull Path filePath, 
List<String> variables) {
     }
 
     public static Config of(@NonNull Map<String, Object> objectMap) {
-        return of(objectMap, false);
-    }
-
-    public static Config of(@NonNull Map<String, Object> objectMap, boolean 
isEncrypt) {

Review Comment:
   Removed the use of 'isEncrypt' to determine whether to decrypt, and called 
it uniformly through the outer layer. Only the conversion is performed here, 
and the deleted code is as follows:
   
   ```
   if (!isEncrypt) {
        config = ConfigShadeUtils.decryptConfig(config);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to