nzw921rx commented on PR #10595: URL: https://github.com/apache/seatunnel/pull/10595#issuecomment-4047378148
Thank you for your detailed review and valuable suggestions. I have carefully reviewed all the issues raised, including **insufficient test coverage**, **potential log security risks**, and **inconsistent decryption calls for the JSON path**, and I fully agree with the improvement recommendations. I will address all the above issues in subsequent pull requests, including but not limited to: 1. Supplement comprehensive test cases covering boundary conditions, multi-format file uploads, error scenarios, and concurrency/performance testing. 2. Add exception handling in `ConfigShadeUtils.processConfig()` to prevent sensitive information from being logged in exception stacks or logs. 3. Unify decryption call approaches to improve code consistency and maintainability. I will submit the follow-up PRs in a timely manner. Please let me know if you have any additional guidance or requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
